Support building FRUT with JUCE 7.0.3 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McMartin
force-pushed
the
support-JUCE-7.0.3
branch
from
7e9ad18
to
7f18cd0
Compare
McMartin
force-pushed
the
support-JUCE-7.0.3
branch
3 times, most recently
from
fdf9605
to
f089e7b
Compare
From the documentation of CMAKE_CXX_STANDARD_REQUIRED: If this property is OFF or unset, the CXX_STANDARD target property is treated as optional and may “decay” to a previous standard if the requested is not available. This means that we keep supporting building FRUT with older versions of JUCE, that require C++11 or C++14.
In juce-framework/JUCE@2e81e8a0d, which was released in JUCE 5.1.0, the per-exporter and per-configuration settings related to the C++ language standard were replaced by a per-project setting (`JUCER_CXX_LANGUAGE_STANDARD`). This commit refactors `_FRUT_set_cxx_language_standard_properties` to match what happened in that JUCE commit and to handle these settings based on JUCER_VERSION instead of whether JUCER_CXX_LANGUAGE_STANDARD is defined.
This matches what was done in juce-framework/JUCE@b3a4d54a7, which was released in JUCE 7.0.3.
7.0.3 is the latest version of JUCE.
McMartin
force-pushed
the
support-JUCE-7.0.3
branch
from
f089e7b
to
e3298a4
Compare
|
@MartyLake please review, thanks! |
MartyLake
reviewed
Dec 12, 2022
| target_compile_options(Jucer2CMake_JUCE PRIVATE -Wno-deprecated-declarations) | ||
| target_compile_options(Jucer2CMake_JUCE PRIVATE | ||
| -Wno-deprecated-declarations | ||
| -Wno-register |
There was a problem hiding this comment.
What is -Wno-register with C++17 ? a new unnecessary warning generated by setting cxx17 ?
There was a problem hiding this comment.
When building older versions of JUCE with C++17 we get:
error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
from third-party libraries included in JUCE (jpglib and zlib). There's nothing much we can do but disable that warning.
MartyLake
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #749