Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial.java clean up #120

Open
gr812b opened this issue May 13, 2024 · 1 comment
Open

Serial.java clean up #120

gr812b opened this issue May 13, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gr812b
Copy link
Collaborator

gr812b commented May 13, 2024

Serial.java file is very messy and difficult to understand. Would be worth a comb over to clarify and clean code. Some of the code, namely the file names that it writes to, is hardcoded as well, which would be nice to one day be able to define on the front end

@gr812b gr812b added enhancement New feature or request good first issue Good for newcomers labels May 13, 2024
@gr812b
Copy link
Collaborator Author

gr812b commented May 13, 2024

This should further be fixed and moved away from static implementation. Quarkus works with managed beans which can have far better control, readability and options outside of what static offers, which is better for a complex system such as one we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant