New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Quarkus Setup #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begun with initial quarkus setup, which includes uploading and downloading files, some application properties and more
This was
linked to
issues
Apr 11, 2024
Closed
Closed
Only getTimespans and toggleLiveData left
…Racing/Better-Data-Viewer into Quarkus-Migration
…Racing/Better-Data-Viewer into Quarkus-Migration
…Racing/Better-Data-Viewer into Quarkus-Migration
gr812b
commented
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Worth looking into Quarkus'
@RestQuery
instead of jakarta's@PathParam
- Exceptions feel a little scuffed around the edges. A sit down to define inheritance, local variables, how to fix errors, feedback, etc
- Are the CI actions updated?
- Does XYColour work?
backend/src/main/java/com/mcmasterbaja/services/DefaultFileMetadataService.java
Show resolved
Hide resolved
backend/src/main/java/com/mcmasterbaja/services/FileMetadataService.java
Outdated
Show resolved
Hide resolved
JAWalmsley
requested changes
May 1, 2024
backend/src/main/java/com/mcmasterbaja/binary_csv/BinaryToCSV.java
Outdated
Show resolved
Hide resolved
JAWalmsley
approved these changes
May 2, 2024
XYColour and CI Actions working in full, all other features seem to still work as well |
camdnnn
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begun with initial quarkus setup, which includes uploading and downloading files, some application properties and more