Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code highlighter: switch to standard hugo highlighter #32

Closed
McShelby opened this issue Jul 25, 2021 · 0 comments
Closed

code highlighter: switch to standard hugo highlighter #32

McShelby opened this issue Jul 25, 2021 · 0 comments
Assignees
@McShelby
Labels
change Introduces changes with existing installations feature New feature or request
Milestone
2.0.0

Comments

@McShelby
Copy link
Owner

Since a while, Hugo has its own mechanism for code highlightning.

We will remove the old highlightning code provided by the client-side javascript library highlight.js and all its related files.

This also solves issues introduced by Hugos own highlightning because in our theme we are currently highlighting the code twice leading to unpredictiable results.

This will also fix an issue were light code highlightning themes weren't displayed correctly because our styles are overwriting color information, see matcornic/hugo-theme-learn#187

Another advantage is the huge list of supported languages which by far exceeds our current list.

On the downside, this is a breaking change because our current color theme isn't supported by Hugo.

Reference: matcornic/hugo-theme-learn#371
@McShelby McShelby added the feature New feature or request label Jul 25, 2021
@McShelby McShelby added this to the Next major milestone Jul 25, 2021
@McShelby McShelby self-assigned this Jul 25, 2021
McShelby added a commit that referenced this issue Jul 26, 2021
@McShelby
code highligher: switch to standard hugo highlighter #32
5c667b3 
Since a while, Hugo has its own mechanism for code highlightning.

We remove the old highlightning code provided by the client-side javascript library highlight.js and all its related files.

This also solves issues introduced by Hugos own highlightning because in our theme we are currently highlighting the code twice leading to unpredictiable results.

This will also fix an issue were light code highlightning themes weren't displayed correctly because our styles are overwriting color information.

Another advantage is the huge list of supported languages which by far exceeds our current list.

On the downside, this is a breaking change because our current color theme isn't supported by Hugo.
McShelby added a commit that referenced this issue Aug 23, 2021
@McShelby
code highlighter: avoid unstyled blocks in docs #32
42c8ec5 
The new highlighter does not work to well if no syntax is specified
for the code block / code fence / indention.
See gohugoio/hugo#8917
McShelby added a commit that referenced this issue Aug 23, 2021
@McShelby
code highlighter: avoid unstyled blocks for indention in docs #32
0d66a97
@McShelby McShelby mentioned this issue Aug 27, 2021
Closed
@McShelby McShelby added the change Introduces changes with existing installations label Nov 19, 2021
@McShelby McShelby changed the title code highligher: switch to standard hugo highlighter code highlighter: switch to standard hugo highlighter Oct 31, 2022
@McShelby McShelby mentioned this issue Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@McShelby McShelby

Labels
change Introduces changes with existing installations feature New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@McShelby