Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to .Net Standard 2.0 - Fix #8 #11

Closed
wants to merge 2 commits into from
Closed

Migrate to .Net Standard 2.0 - Fix #8 #11

wants to merge 2 commits into from

Conversation

Kahbazi
Copy link

@Kahbazi Kahbazi commented Mar 29, 2018

No description provided.

@Mds92
Copy link
Owner

Mds92 commented Mar 29, 2018

Please describe what you did?

@Kahbazi
Copy link
Author

Kahbazi commented Mar 29, 2018

With .Net Standard we are able to write library once and use it across all .Net Environment (.Net Framework 4.6, .NetCore, Xamarin, ...), This link has more info.

I look at your code and if I understand correctly, the two projects MD.PersianDateTime and MD.PersianDateTime.Core are no different in implementation, the source code are the same, the only difference is their target which one in dotnetcore and the other is dotnetframework.

I add a class library project for .Net Standard and add source code from MD.PersianDateTime.Core. So now you have only one project, one source, one nuget package which can be used in both DotNetCore and DotNetFramewrok.

I also took the liberty to change the nuget version to 4.0.0, because DotNetStandard needs Visual studio 2017 v 15.4 and I think it is a major change.

@Mds92
Copy link
Owner

Mds92 commented Mar 29, 2018

Thanks for your notice, But I have to support old .net framework.
If I add another project, I have to support 3 package,

  1. MD.PersianDateTime for .Net Framework 2+
  2. MD.PersianDateTime.Core for .Net Core 2+
  3. MD.PersianDateTime.Standard for newest .Net Framework And .Net Core
    I don't want to expire Project 1
    But I'm going to add Standard project base on requests like Net Standard #8

Thanks anyway

@Mds92 Mds92 added the invalid label Mar 29, 2018
@Mds92 Mds92 closed this Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants