Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use log::debug instead of println #23

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

Be-ing
Copy link
Collaborator

@Be-ing Be-ing commented Apr 4, 2023

to give downstream users the ability to control where the log goes

@Be-ing Be-ing mentioned this pull request Apr 4, 2023
1 task
decode_symphonia/src/lib.rs Outdated Show resolved Hide resolved
decode_symphonia/src/lib.rs Outdated Show resolved Hide resolved
@BillyDM
Copy link

BillyDM commented Apr 6, 2023

Oh yeah, did I give you merge privileges, or do I need to merge this myself? If the second one, is it ready to merge?

@orottier
Copy link
Collaborator

I have addressed @uklotzde comments in a new commit on this branch

@Be-ing
Copy link
Collaborator Author

Be-ing commented Jul 11, 2023

Ready now

to give downstream users the ability to control where the log goes
@orottier orottier merged commit 60496e0 into MeadowlarkDAW:main Jul 11, 2023
3 checks passed
@Be-ing Be-ing deleted the log branch July 11, 2023 18:14
@Be-ing
Copy link
Collaborator Author

Be-ing commented Jul 11, 2023

Shall we make a 1.1 release now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants