Opening archive breaks breadcrumbs

[joshas]

After opening zip archive, navigating inside and going up to parent directory, leaves breadcrumbs in broken state: first item contains path to directory:

To fix it you have to go into child directory.

[MeanEYE]

Thanks. Breadcrumbs are in dire need of some attention. I'll fix this up.

[joshas]

Continuing conversation from #406 about fixing breadcrumbs path inside archive.

Problem is probably here, as this function returns full path to archive as root path:

Sunflower/sunflower/plugins/archive_support/zip_provider.py

Lines 245 to 247 in 20072f7

	def get_root_path(self, path):
	"""Get root for specified path"""
	return os.path.dirname(self._path)

Naive fix would be to change get_root_path result to os.path.sep that always returns root. But what other cases there might be, that this function should be aware of? Archive opened from FTP? From trash list? From another archive?

[MeanEYE]

Aaah, okay. That makes sense now. Basically what's happening is that "get_root_path" is hardcoded in breadcrumbs as /. That's why it looks like that. There are many different cases where root path will be different from usual /. From GVFS to user space mounts, medias, custom providers like WebDAV, etc.

[joshas]

So what would be the best way to get root path here? Could we use pathlib, as none of os.path functions seem to fit without additional string manipulation.

[MeanEYE]

Breadcrumbs should show full root path instead of hard coded /. But once root of current provider is reached we should display path as different provider would see it. That is current behavior as can be seen by icon for the path menu, except when reaching the root of current provider breadcrumbs are not updated to reflect that. Not sure why this is the case.