Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs: fix unnecessary path change #406

Merged
merged 1 commit into from
May 19, 2020

Conversation

joshas
Copy link
Contributor

@joshas joshas commented May 19, 2020

After opening zip archive, breadcrumbs button with current path is activated. That causes first button to get clicked event first and do a path change to parent directory. Combined with provider change that resulted in empty archive listing. Opening zip archive second time works correctly, because breadcrumbs bar is already set to correct location.

When testing current version after opening zip archive one will notice that it has incorrect "folder" icon set and error in terminal complaining about not being able to open directory.

@MeanEYE MeanEYE merged commit 20072f7 into MeanEYE:develop May 19, 2020
@MeanEYE
Copy link
Owner

MeanEYE commented May 19, 2020

Not the best fix, but we'll look into it at some other time.

@MeanEYE
Copy link
Owner

MeanEYE commented May 19, 2020

Hm, breadcrumbs are not working well with these fixes. Even though providers are.
I'll have to check what's up with that.

@joshas
Copy link
Contributor Author

joshas commented May 19, 2020

What problems do you get with breadcrumbs?

@MeanEYE
Copy link
Owner

MeanEYE commented May 19, 2020

It's an unrelated issue to these fixes I think.
When exiting the archive, provider is correct, icon gets updated correctly but breadcrumbs still show root /. That's something I'll have to fix.

@joshas
Copy link
Contributor Author

joshas commented May 19, 2020

I've reported this issue some time ago #332 . I could take a look, probably something with zip provider plugin.

@MeanEYE
Copy link
Owner

MeanEYE commented May 19, 2020

If you wish, you can. Ideally I wanted path to look like /home/meaneye/archive.zip/directory/etc. So user can easily navigate outside of archive. That was the whole point of providers and having multiple provider per each item list.

@MeanEYE
Copy link
Owner

MeanEYE commented May 19, 2020

Also, this would mean we treat archives like any other directory. Which is the end goal.

@joshas
Copy link
Contributor Author

joshas commented May 19, 2020

OK, I'll try to figure out how it actually works and where that "compacted" parent path inside archive comes from.

@MeanEYE
Copy link
Owner

MeanEYE commented May 19, 2020

I think the issue is, at least in part, with changing path to zip archive. Then it gets truncated to a weird one. Going to parent only updates part of it. Either way it's probably something stupidly simple I missed when rewriting breadcrumbs.

Thank you for this PR, am glad archives once again work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants