Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient transfer script #2095

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Patient transfer script #2095

merged 5 commits into from
Oct 17, 2022

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Aug 5, 2022

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@adongare adongare changed the base branch from master to bonnie-on-fhir August 5, 2022 16:17
sb-bdonohue
sb-bdonohue previously approved these changes Aug 5, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #2095 (3653ce1) into bonnie-on-fhir (7f4a71d) will increase coverage by 1.54%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           bonnie-on-fhir    #2095      +/-   ##
==================================================
+ Coverage           69.37%   70.91%   +1.54%     
==================================================
  Files                 196      140      -56     
  Lines               10662     8356    -2306     
  Branches             1270     1270              
==================================================
- Hits                 7397     5926    -1471     
+ Misses               2663     1828     -835     
  Partials              602      602              
Impacted Files Coverage Δ
lib/assets/hqmf_template_oid_map.rb
...llers/doorkeeper_override/token_info_controller.rb
app/helpers/excel_export_helper.rb
app/helpers/virus_scan_helper.rb
config/initializers/wrap_parameters.rb
config/initializers/tilt.rb
lib/saml_failure_handler.rb
config/security_patch_cve20205267.rb
config/initializers/session_store.rb
lib/tasks/cql.rake
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4a71d...3653ce1. Read the comment docs.

@adongare adongare merged commit b4dca91 into bonnie-on-fhir Oct 17, 2022
@adongare adongare deleted the patient_transfer_script branch October 17, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants