Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-4242 Export from Bonnie FHIR Individual Test Cases #2097

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

adongare
Copy link
Contributor

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #2097 (d2694cd) into bonnie-on-fhir (118d346) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           bonnie-on-fhir    #2097      +/-   ##
==================================================
- Coverage           69.41%   69.37%   -0.05%     
==================================================
  Files                 196      196              
  Lines               10654    10662       +8     
  Branches             1270     1270              
==================================================
+ Hits                 7396     7397       +1     
- Misses               2655     2663       +8     
+ Partials              603      602       -1     
Impacted Files Coverage Δ
app/assets/javascripts/application.js.coffee 72.22% <ø> (ø)
...pp/assets/javascripts/views/measure_view.js.coffee 38.29% <80.00%> (-1.71%) ⬇️
app/assets/javascripts/models/coverage.js.coffee 96.92% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118d346...d2694cd. Read the comment docs.

@adongare adongare marked this pull request as ready for review September 27, 2022 21:14
@adongare adongare merged commit 7f4a71d into bonnie-on-fhir Oct 6, 2022
@adongare adongare deleted the MAT-4242 branch October 17, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants