Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cqm-execution for updated FHIR Bundle export #2111

Conversation

jkotanchik-SB
Copy link
Contributor

Bump cqm-execution commit for updated FHIR Bundle export.

Override minimist dep version to resolve vuln.

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR: MAT-5061, MAT-5063
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner December 2, 2022 17:25
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #2111 (34a1e46) into bonnie-on-fhir (a120d4a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           bonnie-on-fhir    #2111   +/-   ##
===============================================
  Coverage           69.32%   69.32%           
===============================================
  Files                 196      196           
  Lines               10657    10657           
  Branches             1270     1270           
===============================================
  Hits                 7388     7388           
  Misses               2665     2665           
  Partials              604      604           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a120d4a...34a1e46. Read the comment docs.

@jkotanchik-SB jkotanchik-SB merged commit 2f122fe into bonnie-on-fhir Dec 2, 2022
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-5061-5063-updates-to-patient-bundle-export branch December 2, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants