Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7310: Append includeDraft=true to FHIR Term requests when Latest is selected (manifest is null). #85

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Jun 11, 2024

Terminology Service PR

Jira Ticket: MAT-7310
(Optional) Related Tickets:

Summary

Match our FHIR Term "Latest" calls with SVS "Latest" calls by appending includeDraft=true to "Latest" FHIR Term requests.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner June 11, 2024 19:16
@jkotanchik-SB jkotanchik-SB self-assigned this Jun 11, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7310-include-drafts-with-latest branch from f68ec44 to 355072d Compare June 11, 2024 19:23
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.55%. Comparing base (9393c2a) to head (355072d).
Report is 6 commits behind head on develop.

Current head 355072d differs from pull request most recent head 07ec3da

Please upload reports for the commit 07ec3da to get more accurate results.

Files Patch % Lines
...madie/terminology/util/TerminologyServiceUtil.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #85      +/-   ##
=============================================
- Coverage      76.80%   76.55%   -0.25%     
  Complexity       224      224              
=============================================
  Files             23       23              
  Lines            927      930       +3     
  Branches          76       77       +1     
=============================================
  Hits             712      712              
- Misses           178      180       +2     
- Partials          37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…is selected (manifest is null).

This will match our SVS "Latest" request style of always including drafts.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7310-include-drafts-with-latest branch from 355072d to 07ec3da Compare June 11, 2024 19:44
@jkotanchik-SB jkotanchik-SB merged commit 7a283e8 into develop Jun 11, 2024
6 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7310-include-drafts-with-latest branch June 11, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants