Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAT-7233] Bubble up VSAC FHIR Term Service Error Responses #86

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

Terminology Service PR

Jira Ticket: MAT-7233
(Optional) Related Tickets:

Summary

Since there is an unknown number of error cases, bubble up the error message returned from VSAC's FHIR Terminology Service.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB self-assigned this Jun 13, 2024
@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner June 13, 2024 17:22
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7233-return-fhir-term-error-msgs branch from 8a855b7 to a458f77 Compare June 13, 2024 17:32
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7233-return-fhir-term-error-msgs branch from a458f77 to 37b3d7f Compare June 14, 2024 14:11
@MeasureAuthoringTool MeasureAuthoringTool deleted a comment from nmorasb Jun 14, 2024
…tionOutcome Resource and return the diagnostic message to the caller.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7233-return-fhir-term-error-msgs branch from 37b3d7f to 74bcb2f Compare June 14, 2024 14:13
@jkotanchik-SB jkotanchik-SB merged commit 6bc4cf5 into develop Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants