Fix 2511 wds #28
Closed
Fix 2511 wds #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this would make a difference but the explicit addition of a NULL byte to the end of the string in the specification made me think this should be done.
An incomplete unattend.xml no longer throws a NoMethodError on nil, instead just advises that the file is incomplete.
wchen-r7
added a commit
that referenced
this pull request
May 19, 2015
More rapid7#5287 RPC API fixes
Meatballs1
pushed a commit
that referenced
this pull request
Jul 17, 2016
Added error checking and some suggested style changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to clean up the WDS module to disconnect after each RPC attempt.
Still kind of flaky, though. Any ideas?
It definitely fixes up the committed module, so I don't mind landing this as is if @Meatballs1 or @jlee-r7 doesn't have time to look at it, but this solution is incomplete.