Feature/metaballs1/enum ad users #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author sections are fixed
This removes checked-in sniffer extension in favor of the gem-packaged version. It also pulls in the changes for verifying rapid7#4411
The metcli.exe binary doesn't get used any more and the source was removed from Meterpreter ages ago. No point in having it in the repo any more.
* Avoid retrying logins when connection cannot be stablished
these fields should never change, so put the array in a constant and freeze it to prevent accidental tampering
move the filter_string into a seperate method and use shovel oeprator to keep it a little cleaner
moved the result parsing into its own method cleaned up run method a bit more, added YARD docs to the new methods
|
arg issued against wrong branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with some code style cleanup for your enum_ad_users post module from rapid7#4392
Just some minor style tweaks to make the code a little cleaner. Also merged in the latest version of framework master to make sure it's using latest metasploit-credential. With these changes I do not see any of the errors that @jvazquez-r7 was seeing.