Tag type maching case sensitive

[Pimmetje]

When the form uses upper casing the matching would fail.

MechanicalSoup/mechanicalsoup/browser.py

Line 166 in 5926d0e

if tag.get("type") in ("radio", "checkbox"):

Suggest adding .lower()
if tag.get("type").lower() in ("radio", "checkbox"):

[moy]

Not sure the upper-case version is correct HTML, but anyway, we should be tolerant in what we accept.

Patch follows.

[Pimmetje]

Never trust user input :)

I could not find any hard reference but this one comes close to what i think is right https://stackoverflow.com/a/19808575/559333

[moy]

The stackoverflow link is about tag names, but the issue here is about the attribute's content.

[Pimmetje]

Your right: That asks for more research.
"Attribute names are case-insensitive, but attribute values may be case-sensitive." [1]
So i guess you could be right.
If i read [2] i get the feeling this reference is more like u have to use the same casing in the document. But i can't find a reference stating the case requirements for basic attributes. So i think it's best to assume they could be anything.

[1] http://www.htmlhelp.com/reference/html40/structure.html#attributes
[2] http://www.htmlhelp.com/reference/html40/values.html

[moy]

Anyway, "how HTML should be?" is not very important in real life for tools like MechanicalSoup. "How the HTML you're parsing is?" is the right question (somehow, well-designed websites have a proper API to avoid having to parse HTML, so they don't need MechanicalSoup ...).