Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature -- Create Missing Artifacts #2

Merged

Conversation

chuckbergeron
Copy link
Contributor

@chuckbergeron chuckbergeron commented Jan 9, 2019

This will generate any artifact files in the output artifacts directory which did not exist in the input artifacts directory.

For instance, if the input directory has a 'Migrations.json' artifact, and a networks file has contract addresses for 'Migrations' and 'SimpleToken', then the output artifact directory will have both artifacts for 'Migrations' and 'SimpleToken'.

This is useful when you manually add contract addresses (possibly which others have deployed to testnets, mainnets, etc) to a networks file and want to consume addresses in the artifacts files.

@asselstine
Copy link
Contributor

@chuckbergeron Could you close and reopen this one? Github seems to think there are way more changes

Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things, otherwise it looks good to me

lib/processAllArtifacts.js Outdated Show resolved Hide resolved
lib/processAllArtifacts.js Outdated Show resolved Hide resolved
@asselstine
Copy link
Contributor

Ah- also maybe add a mention in the readme that input artifacts aren't strictly needed. Perhaps something like 'merge into existing Truffle artifacts or create new ones'. Maybe even a short section?

@chuckbergeron
Copy link
Contributor Author

@asselstine Readme updated and Promises converted to async/await !

@asselstine asselstine merged commit aac2e60 into MedXProtocol:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants