Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that embedded MD5 exists before verifying or embedding #255

Open
MarcosSueiro opened this issue Mar 24, 2023 · 0 comments
Open

Check that embedded MD5 exists before verifying or embedding #255

MarcosSueiro opened this issue Mar 24, 2023 · 0 comments

Comments

@MarcosSueiro
Copy link

I could not tell from the code (just from the time it takes to implement the function), but it seems BWFME calculates an MD5 before embedding it with --MD5-embed. This makes the process potentially much slower, especially when implementing these functions on a large set of files that includes a subset of files with embedded MD5 data.

A logical sequence for both --MD5-Verify and --MD5-embed (although perhaps not so for --MD5-embed-overwrite) might be:

  1. Read the file to see if MD5 data exists in the file
  2. If yes to (1), calculate the MD5
  3. (Verify) or (Embed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant