Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Prevent repeated execution of certain code #853

Merged
merged 2 commits into from
May 31, 2024

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented May 31, 2024

Ensure code that is only necessary to execute once on application start-up is not repeated every time FormShow is called such as when switching dark mode.

Resolves bugs mentioned in #836 (comment)

Also makes dark mode switching faster.

PR #851 and #852 no longer needed. Now the view will not change when switching dark mode.

@JeromeMartinez
Copy link
Member

PR #851 and #852 no longer needed.

They are already merged, please rebase and remove them in your PR.

Ensure code that is only necessary to execute once on application start-up is not repeated every time FormShow is called such as when switching dark mode.
@cjee21
Copy link
Collaborator Author

cjee21 commented May 31, 2024

Okay, dark mode switching should work well now and without resetting to basic view.

@cjee21
Copy link
Collaborator Author

cjee21 commented May 31, 2024

Removed commented-out testing code that I accidentally left there.

@cjee21
Copy link
Collaborator Author

cjee21 commented May 31, 2024

Oh no, HTML view is a little buggy now. Maybe need to put a refresh somewhere.

@cjee21
Copy link
Collaborator Author

cjee21 commented May 31, 2024

I can't figure out what is going on with HTML view now. It's a minor issue where HTML has to be clicked 2 times after switching dark mode else it is blank.

@JeromeMartinez
Copy link
Member

It's a minor issue where HTML has to be clicked 2 times after switching dark mode else it is blank.

I can reproduce this issue but I'll survive with it for the moment :).

Copy link
Member

@JeromeMartinez JeromeMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not perfect but a lot better than before so I merge that.

@JeromeMartinez JeromeMartinez merged commit 2dceecb into MediaArea:master May 31, 2024
2 of 3 checks passed
@cjee21
Copy link
Collaborator Author

cjee21 commented May 31, 2024

An unrelated issue I found while testing is that if debug mode is toggled, the text view will be blank no matter what is toggled until application restart. I am not sure how debug mode is supposed to be used though.

@JeromeMartinez
Copy link
Member

General information: the code is very old (really... ~20 years) and messy, lot of unnecessary UI updates, we don't have much time on our side for it but if you are motivated we would be happy that you make it simpler.

Thank you again for your work.

@JeromeMartinez
Copy link
Member

if debug mode is toggled, the text view will be blank no matter what is toggled until application restart. I am not sure how debug mode is supposed to be used though.

Drag and drop again a file :).
It should analyse automatically the file with the new option but it was not implemented due to lack of time, not a big deal but it would be great it you update that.

@cjee21
Copy link
Collaborator Author

cjee21 commented May 31, 2024

Thank you again for your work.

Glad to help.

Drag and drop again a file :). It should analyse automatically the file with the new option but it was not implemented due to lack of time, not a big deal but it would be great it you update that.

Don't think I will do anything about that since I don't need that and no idea how to do. 😄

Noticed the contents of View -> Your system doesn't seem to correlate with the 3 radio button selections too but I don't use this page also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants