Add Flac to Samsung direct play profile #1030
Conversation
Add Flac to Samsung direct play profile
|
My first pull request, needs to be checked |
thanks to match the others it should have had new DirectPlayProfile. Hopefully ive updated it
|
its apparent im confused by github, i thought i had replicated the structure before...i edited it again to include your suggestion..but i cant see my correction :-( |
|
It's there now, your second commit showed up in this pull request. Click commits up top to see the second commit showed up, and then click files changed to see the final outcome of the 2 commits. |
|
thanks, its making a bit more sense...do i just wait now for an owner to accept or reject? is it submitted for review? do i need to close it to submit it? |
|
You are done. The Pull Request is submitted. One of the owners will review when they have time, and then they will either accept, reject, or ask for some changes. Might take a while, those guys have a lot on their plates. |
|
Does this work for all samsungs? what year did they start supporting flac? |
|
my 2012 model supports flac..i assume all later do as well ..but have not done any investigation..maybe a second samsung profile is a safer way to go..that said the number of unsupported tvs must be diminishing towards zero over time |
|
merged manually |
Add Flac to Samsung direct play profile.
Samsungs from 2012 support this..so if Flac support isnt universal for all Samsungs, it is most common...