Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate points in bounding box with padding #10

Merged
merged 1 commit into from
May 9, 2018

Conversation

AlphaHydrae
Copy link
Member

This is to facilitate end-to-end tests in the frontend. To ensure that
no markers appear out of the bounds of the screen when displaying a map,
the window width/height ratio can be adjusted to the be the same as the
bounding box, and a padding can be applied to ensure that markers that
would be at the very edge of the screen are well within the screen
instead.

@AlphaHydrae AlphaHydrae requested a review from Tazaf May 4, 2018 12:55
@coveralls
Copy link

coveralls commented May 4, 2018

Coverage Status

Coverage increased (+0.5%) to 90.725% when pulling 1e0fedc on bbox-padding into c557cc6 on sprint-1-discovering-biodiversity.

This is to facilitate end-to-end tests in the frontend. To ensure that
no markers appear out of the bounds of the screen when displaying a map,
the window width/height ratio can be adjusted to the be the same as the
bounding box, and a padding can be applied to ensure that markers that
would be at the very edge of the screen are well within the screen
instead.
@Tazaf Tazaf merged commit 0d8916b into sprint-1-discovering-biodiversity May 9, 2018
@Tazaf Tazaf deleted the bbox-padding branch May 9, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants