Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssid parameter of WiFi.begin() is not const ? #12

Closed
SmallpTsai opened this issue May 14, 2017 · 0 comments · Fixed by #14
Closed

ssid parameter of WiFi.begin() is not const ? #12

SmallpTsai opened this issue May 14, 2017 · 0 comments · Fixed by #14
Assignees
@pablosun
Labels
bug

Comments

@SmallpTsai
Copy link

SmallpTsai commented May 14, 2017 •
edited

Should first parameter be const in WiFi.begin API ?

+ int begin(const char* ssid, const char *passphrase);
- int begin(char* ssid, const char *passphrase);
pablosun added a commit that referenced this issue May 19, 2017
@pablosun
Fix #12 by correcting input parameter const-ness
a74e11b
@pablosun pablosun mentioned this issue May 19, 2017
Merged
@pablosun pablosun self-assigned this May 19, 2017
@pablosun pablosun added the bug label May 19, 2017
pablosun added a commit that referenced this issue May 19, 2017
@pablosun
Implement #8: Support SSL/TLS connection by adding TLSClient
8db6ec2 
We add a new `TLSClient` class as part of the LWiFi library, it

* Wraps mbedTLS calls
* Provide an example that connects to http://howsmyssl.com

Some implementation details:

 * mbedTLS is already in the liblinkit.a
* Switch the default mbedTLS config file to config-mtk-websocket.h which have a larger TLS content buffer.
 * Increase FreeRTOS heap size to 120KB because increasing the TLS content buffer results in larger heap memory usage.
 * Also fixes #12 by correct use `const char*` in ssid parameter in `WiFi` APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablosun pablosun

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8: Support SSL/TLS connection by adding TLSClient MediaTek-Labs/Arduino-Add-On-for-LinkIt-SDK
2 participants
@SmallpTsai @pablosun