Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matador to use new soynode #176

Merged
merged 1 commit into from Jan 20, 2017
Merged

Update matador to use new soynode #176

merged 1 commit into from Jan 20, 2017

Conversation

valueof
Copy link
Contributor

@valueof valueof commented Jan 20, 2017

Hello @kylehg,

Please review the following commits I made in branch 'valueof/update'.

d59c6d6 (2017-01-20 15:45:48 -0800)
Update matador to use new soynode

R=@kylehg

MANUAL TESTING=yes

Code review reminders. By giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to our style guides
  • Incomplete code is marked with TODOs
  • Logging and metrics are suitable

@valueof valueof merged commit 328eeef into master Jan 20, 2017
@valueof valueof deleted the valueof/update branch January 20, 2017 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehg kylehg kylehg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valueof @kylehg