This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Default to user agent string in npm config if it is provided #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,7 +232,8 @@ function getRequestOptions(conf) { | |||
| options.proxy = proxyUrl | |||
|
|
|||
| // If going through proxy, spoof the User-Agent, since may commerical proxies block blank or unknown agents in headers | |||
| options.headers['User-Agent'] = 'curl/7.21.4 (universal-apple-darwin11.0) libcurl/7.21.4 OpenSSL/0.9.8r zlib/1.2.5' | |||
| var userAgent = conf.get('user-agent') || 'curl/7.21.4 (universal-apple-darwin11.0) libcurl/7.21.4 OpenSSL/0.9.8r zlib/1.2.5' | |||
There was a problem hiding this comment.
i don't think this will do what you expect, because user-agent is never empty. you can just remove the ||
This user agent string can be overriden through the 'npm config' utility
|
Good point! I removed the unnecessary default settings in the latest commit. I think you might hear some grumbling about needing to run "npm config set user-agent" with this commit, but I think it's the right way to solve the proprietary http proxy issue. Please take a look at your earliest convenience. |
|
thanks! |
nicks
added a commit
that referenced
this pull request
Feb 18, 2015
Default to user agent string in npm config if it is provided
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some workplaces, the network http proxy is very restrictive and restricts the traffic to very specific user agent strings. This patch should make it so that the phantomjs install script respects the user agent string specified in the npm config.