This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Make sure the fist item in the ca array actually contains a certificate #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 😭 😭 can you squash the commits? |
ChadKillingsworth
force-pushed
the
fix-ca-option
branch
from
97ebd80
to
d5b2d84
Compare
|
Done. I was surprised you subscribed to the "no-semicolons" philosophy. |
|
join the dark side of no-semicolons! 😈 |
nicks
added a commit
that referenced
this pull request
Jan 29, 2016
Make sure the fist item in the ca array actually contains a certificate
|
Can you cut a release with this? I've got team members anxious to use it. |
|
oops! i thought i did. done! On Fri, Feb 5, 2016 at 11:56 AM, Chad Killingsworth <
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a cafile option with npm, the file might contain comments (like when you base it off of the main node root certs file)
In this case, the first entry in the ca option from the split isn't a valid cert, and the whole thing is ignored.
I really wish there was an option to make node/npm use the system certs...