This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Backport GitHub release changes to phantomjs 1.9.7 #538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phantomjs 1.9.8 had a major regression over 1.9.7 (ariya/phantomjs#12697) that caused a lot of pain for mocha-phantomjs users (nathanboktae/mocha-phantomjs#167). This PR is a request to please backport the GitHub release changes to 1.9.7 as well.
I fully expect you to create a new branch for this, and I did choose
v1.9.15
as the release tag since it is missing anyways currently, as well as that's the version mocha-phantomjs is pegged at.