Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Backport GitHub release changes to phantomjs 1.9.7 #538

Closed

Conversation

nathanboktae
Copy link

Phantomjs 1.9.8 had a major regression over 1.9.7 (ariya/phantomjs#12697) that caused a lot of pain for mocha-phantomjs users (nathanboktae/mocha-phantomjs#167). This PR is a request to please backport the GitHub release changes to 1.9.7 as well.

I fully expect you to create a new branch for this, and I did choose v1.9.15 as the release tag since it is missing anyways currently, as well as that's the version mocha-phantomjs is pegged at.

@nathanboktae
Copy link
Author

Any updates on this? This failing because I can't create the new GitHub release it is looking for.

@nicks nicks closed this May 13, 2016
@nicks
Copy link
Contributor

nicks commented May 13, 2016

I don't think we should be backporting patch versions to earlier patch
versions. It gets way too confusing.

i.e., once version 1.9.8 is out, we will not be creating any more
installers for 1.9.7. If the bug fix is important enough, then it should be
released as 1.9.9. Or you could upgrade 2.x.

On Fri, May 13, 2016 at 12:52 PM, Nathan Black notifications@github.com
wrote:

Any updates on this? This failing because I can't create the new GitHub
release it is looking for.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#538 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants