Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Upgrade some deps #653

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Upgrade some deps #653

merged 1 commit into from
Dec 9, 2016

Conversation

nicks
Copy link
Contributor

@nicks nicks commented Dec 9, 2016

Hello @nicks,

Please review the following commits I made in branch 'nicks/bump'.

379d3ae (2016-12-09 12:01:16 -0500)
Upgrade some deps

R=@nicks

@nicks nicks merged commit 750d5f3 into master Dec 9, 2016
@nicks nicks deleted the nicks/bump branch December 9, 2016 17:07
@jerry98225
Copy link

jerry98225 commented Dec 10, 2016

It breaks our build process after you upgrade some deps.
We use Jenkins and it fails with the following message:
[exec] npm ERR! phantomjs-prebuilt@2.1.14 install: node install.js
[exec] npm ERR! Exit status 8
[exec] npm ERR!
[exec] npm ERR! Failed at the phantomjs-prebuilt@2.1.14 install script 'node install.js'.
[exec] npm ERR! This is most likely a problem with the phantomjs-prebuilt package,
[exec] npm ERR! not with npm itself.
[exec] npm ERR! Tell the author that this fails on your system:
[exec] npm ERR! node install.js

It worked fine before this request get merged.

We can't just simply downgrade the version because it's another dependency that requires 2.1.14.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants