Danfuzz pause default #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2012 10:32
These had been paused by default, but that can be pretty confusing. It *used* to be that there was no compelling reason not to start out paused, but at this point, the module does event sanitization, and that means there is now a use case for paused == `false` that can be expected to be common enough. With this change, the only class that starts out paused is `Blip`, because there is truly no sense in doing otherwise.
| @@ -222,7 +222,7 @@ function readableTransition() { | |||
|
|
|||
| var blip = makeErrorBlip(new Error("eek")); | |||
| var coll = new EventCollector(); | |||
| cat = new Cat([blip]); | |||
| cat = new Cat([blip], true); | |||
There was a problem hiding this comment.
Aside:
i think it's an antipattern to pass in true/false in methods like this and instead use differently named methods. Since this is a constructor, it may be worth creating factory methods to create Cats, soething like Cat.paused(), etc.
There was a problem hiding this comment.
Yeah, point taken. I was on the fence about how to do this. On the one hand, dominant style seems to encourage new Blah() over createBlah(). On the other, what you said.
|
LG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the default
pausedargument onCatandValvefromfalsetotrue. See docs and the main commit for details./cc @azulus because I think he's interested.
I'm not going to wait for review, since this is pretty straightforward and I want to move on to adjusting the dependent code. As always, I'm happy to do post-merge tweaks as needed.