Factor out character decoder from Pipe class. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it reusable in some upcoming additions.
|
/cc @mikefleming |
| */ | ||
| function isValid(encodingName) { | ||
| switch (encodingName) { | ||
| case undefined: |
There was a problem hiding this comment.
This works and I believe is correct per-spec.
|
LGTM I think I'll get in the habit of using Object.freeze after my class definitions too. |
|
Thanks! And re: freeze(), yeah, it seems like a pretty sane thing to do to me. |
danfuzz
added a commit
that referenced
this pull request
Jun 20, 2012
Factor out character decoder from Pipe class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it reusable in some upcoming additions.