Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge MIP-112 & MIP-127 #3762

Merged
merged 44 commits into from
May 24, 2024
Merged

Merge MIP-112 & MIP-127 #3762

merged 44 commits into from
May 24, 2024

Conversation

ahamdi
Copy link
Member

@ahamdi ahamdi commented May 3, 2024

No description provided.

@boubaker boubaker linked an issue May 5, 2024 that may be closed by this pull request
@boubaker boubaker linked an issue May 7, 2024 that may be closed by this pull request
@ahamdi ahamdi self-assigned this May 10, 2024
@ahamdi ahamdi force-pushed the Merge/MIP-112 branch 2 times, most recently from dc21633 to 75cd7f9 Compare May 22, 2024 12:24
hakermi and others added 22 commits May 22, 2024 14:00
…o/MIPs#112 (#3542)

Prior to this change, when open the profile contact information edit
drawer and remove or add managers then close it without save and open it
again will cause an issue related to the update of the managers
property.
This PR will make sure reinitialize the properties to saved list each
open of the drawer to avoid such issue.
…ravatar component - EXO-69207 - Meeds-io/MIPs#112 (#3537)

Add a disabled indication icon for disabled users in common useravatar
component

This fix will also :
 - variabilize the properties of Profile search index
 - add the connection field explicitely to the profile ES index
…3618)

Latest changes caused that the user avatar appears in the middle
vertically when displayed in user comments on social activities. The fix
removes the extra div and adds the boolean **show** inside both cases,
this simplifies the DOM structure and avoids the regression
…#112 (#3619)

fix Display issue in chart setup preview due to the compatibility of
transform-origin property on different browsers
…O-69789 - Meeds-io/MIPs#112 (#3626)

this PR fixes:
1- no subordinate list caused unhandled case in search query with
multivalued properties
2 - set i18n header title option
3 - hover effect on cog icon in chart settings is not circeled 
4 - fix display of manageduserscount in managers cards
…user via settings - EXO-69787 - Meeds-io/MIPs#112 (#3642)

Add a portlet preference to disable the update of chart center user via
settings
…on available for current language - EXO-70024 - Meeds-io/MIPs#112 (#3654)

Ensure to set default configured header title when no translation
available for current language
hakermi and others added 22 commits May 22, 2024 14:00
…Meeds-io/MIPs#112 (#3685)

prior to this change, when select a user from chart settings drawer, the
chart preview always show the preview chart of connected user, due to an
unhandled issue when extracting the user id from url in case of preview
which should be prevented.
This PR make sure to prevent the extract or the update of the user from
the url in case of preview
…r - EXO-69210 - Meeds-io/MIPs#112 (#3669)

Add organizational chart CTA button option in user popover
…ds-io/MIPs#112 (#3701)

issue with top border radius of new user card after adding additional
adaptation with space members which cause a hide of top border radius by
the banner image.
This PR makes sure to correctly display the top border radius by
correctly place the additional tags inside v-img
…o/MIPs#127

ui/ux and accessibility issues in user card :
fix user role icons titles on hover
fix accessibilty labels in user card action vuttons
…load a vue component as extension - EXO-71271 - Meeds-io/MIPs#127

Before this fix, the extension point in user card for profile action, is only able to display and icon, with a onclick action.
In some cases, we need to load a complete vue component.
This fix update the extension point to able to load such component
…o/MIPs#133

Prior to this change, the LocaleConfigService returns some locales with '_' while the Translation service works with '-' separator. This changes ensures to transform languages retrieved from LocaleConfigService to make it compatible with TranslationService.
…meeds#112 - EXO-71405 (#3729)

in this fix we renamed the AMD module of the organization chart
extensions to make it load automatically with the User Popover
…XO-71348 (#3791)

The fix will :
 - set the size of the menu and the role icons of the user card to 24px
 - add a border to the role icon in space members
…EXO-71312 (#3784)

Before this fix, the 3-dots menu was not displayed for the current user.
The fix enables the 3-dots menu and the user can open his Org chart page
from his user card.
…-io/MIPs#112 - EXO-71284 (#3792)

External users could edit their personal profiles, but they should not
have access to the list of users on the platform.
If the profile contain a property of type user, they could get the list
of users, thus those type of fields will be disabled for them by the
current fix.
…/meeds#127 - EXO-71337 (#3783)

Before this fix, we used the Setting Rest service to load the user card
properties. This didn't work for simple users as this Rest service does
not return settings when the Context is Global.
The fix creates a new Rest endpoint to return the card settings from
User Rest service
…ds#127 - EXO-71336 (#3785)

Allow the email field to be listed with proposed fields for the user
card by using all the available visible properties and eliminating just multi valued properties, parent properties and Unhiddenable properties.
…ager is inactive - Meeds-io/meeds#112 - EXO-71333 (#3773)

When the profile property **manager** is inactive, the Org chart button
in the user card & user popover will be hidden.
besides, a message will be displayed in the Org chart application
indicating that the property manager is inactive and the content of the
application will be hidden.

This fix introduces a listener for changes on Profile property settings
to hide/show those pages when the manager field is updated. It uses
pages permission to perform this action.

the fix will give all permissions on the page to root if the field is
disabled, otherwise, access permission will be granted for all users and
all the edit permissions will be granted for administrators.
…EXO-69915 - Meeds-io/meeds#112 (#3766)

Multi-value properties should not be parent properties too.
The fix will not add a multivalue property to the list of parent when
adding or editing a profile property.
…ds-io/MIPs#112 - EXO-69857 (#3817)

Receive and map correctly the multivalued profile property and avoid
losing its list of values. the property manager is multi-value when
users are stored in DB or in LDAP. But it is single value for Active
directory. This fix makes sure to parse it correctly to get the value
and convert it to the selected user.
…ment - Meed-io/meeds#112 - EXO-71745  (#3819)

Remove inline variable declaration when initiating Org cart application,
to avoid the issue when loading it with layout management
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
50.2% Coverage on New Code (required ≥ 60%)
1 New Critical Issues (required ≤ 0)
1 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ahamdi ahamdi merged commit 153267c into develop May 24, 2024
4 of 5 checks passed
@ahamdi ahamdi deleted the Merge/MIP-112 branch May 24, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space members and people page UI/UX enhancement Oganizational Chart
4 participants