Skip to content

Commit

Permalink
fix(rccl): fix rccl compile
Browse files Browse the repository at this point in the history
GitOrigin-RevId: e3a18dc052a3e218482ce796b0f7b59c165cc2ad
  • Loading branch information
megvii-mge authored and hxdmegvii committed Jun 30, 2022
1 parent dd49800 commit aca4005
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/rccl/communicator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@

#include "rccl.h"

#include "megray/debug.h"
#include "megray/hip_context.h"

#include "utils.h"

#define CHECK_LAUNCH_MODE \
Expand Down Expand Up @@ -59,7 +61,7 @@ Status RcclCommunicator::do_init(BcastCallback cb) {
}
cb(uid.internal, NCCL_UNIQUE_ID_BYTES);
m_rccl = std::make_unique<RcclCommunicatorPrivate>();
RCCL_CHECK(ncclCommInitRank(&m_nccl->m_comm, m_nranks, uid, m_rank));
RCCL_CHECK(ncclCommInitRank(&m_rccl->m_comm, m_nranks, uid, m_rank));
return MEGRAY_OK;
}

Expand Down Expand Up @@ -231,13 +233,13 @@ Status RcclCommunicator::reduce(const void* sendbuff, void* recvbuff,
}

Status RcclCommunicator::group_start() {
MEGRAY_RCCL_ERR("megray: not impl group end");
return MEGRAY_OK;
MEGRAY_ERROR("megray: not impl group end");
return MEGRAY_NOT_IMPLEMENTED;
}

Status RcclCommunicator::group_end() {
MEGRAY_RCCL_ERR("megray: not impl group end");
return MEGRAY_OK;
MEGRAY_ERROR("megray: not impl group end");
return MEGRAY_NOT_IMPLEMENTED;
}


Expand Down

0 comments on commit aca4005

Please sign in to comment.