Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Cargo Space' cannot be removed from canon units #136

Closed
RexPearce opened this issue Jan 24, 2018 · 1 comment
Closed

'Cargo Space' cannot be removed from canon units #136

RexPearce opened this issue Jan 24, 2018 · 1 comment
Labels
Milestone

Comments

@RexPearce
Copy link
Collaborator

Some canon units, e.g. the J-37 Ordnance Transport have built-in cargo space, described as: "Cargo Space (1 door) - 21 tons".

This equipment cannot be removed in Mek Lab, limiting the usefulness of these units as bonus vehicles in MekHQ AtB. Otherwise this cargo space could be refitted with weapons or troop space.

Not sure if a "Fixed Cargo Space" field (similar to "Fixed Troop Space") in the chassis section will do, or something more complicated is required.

Note: this also affects VTOLS (e.g.Ferret Light Scout VTOL (Cargo)") and conventional fighters (e.g. "Planetlifter Air Transport (Standard)") as well, and probably other unit types.

@neoancient neoancient changed the title [0.43.7-RC1] 'Cargo Space' cannot be removed from canon units 'Cargo Space' cannot be removed from canon units Jan 26, 2018
@neoancient neoancient added the Bug label Jan 26, 2018
@Dylan-M Dylan-M added Bug and removed Bug labels Feb 11, 2018
@Dylan-M Dylan-M added this to the Stable 0.44 milestone Feb 11, 2018
@neoancient
Copy link
Member

There are really two issues here. The first is that vehicle cargo space cannot be edited. The second is that the J-37 is a support vehicle, and MML should not allow loading support vehicles for editing until it has support for the construction rules.

The simplest solution for the first issue would be to add a control for setting the amount of cargo space. This is an incomplete solution because it does not account for specialized bay types (liquid, livestock, refrigerated, etc.). Doing so would probably require adding a separate transport panel, which should not be too difficult.

The easiest way to deal with the second issue would be to use a popup alert informing the user that the operation is unsupported and refusing to load the unit. This is what currently happens if you try to load, for instance, a warship (though the message could be clearer). With vehicles this is less ideal as the combat and support vehicles are not distinguished in the unit selector and it's not clear until you try to load it whether it is supported or not. But because I plan to add support vehicle construction in the near future this may be tolerable for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants