Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superheavy critical space #21

Closed
alexbib opened this issue Jul 5, 2016 · 1 comment
Closed

Superheavy critical space #21

alexbib opened this issue Jul 5, 2016 · 1 comment
Assignees
Labels

Comments

@alexbib
Copy link

alexbib commented Jul 5, 2016

It seems that crit slots for superheavy mechs are still not computed properly. The critical slots required by the engine, armor and possibly cockpit components should be halved (in the rules it says it applies to everything except actuators and internal structure). Right now in Megameklab it works only for heat sinks and equipment you add from the equipment panel.

@arlith arlith closed this as completed in d8edbd9 Jul 31, 2016
@arlith
Copy link
Member

arlith commented Jul 31, 2016

When I tested it, internals (superheavy endo-steel) and engines worked. What didn't work was armor and the gyro. Halving armor crits was done in MM in commit MegaMek/megamek@6ff9bc9. I also added the superheavy gyro in MegaMek/megamek@e2bb623.

I also found that the Engine and Gyro criticals, while technically correct, weren't always updated properly when switching between superheavy and non-superheavy. I updated some code in MML fix this.

It seems like all of the critical accounting for superheavies works now.

@arlith arlith added the Bug label Jul 31, 2016
@arlith arlith self-assigned this Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants