Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing DropShip engine from military to civilian does not update displayed information #670

Closed
assaultdoor opened this issue Jul 7, 2020 · 0 comments · Fixed by #686
Closed

Comments

@assaultdoor
Copy link

Using MML 0.47.7 on OS X with Java build 1.8.0_51-b16, if I toggle the Military checkbox, the displayed Burn Days 1G for fuel usage does not change. Neither do the number of free heat sinks or the available Tonnage at the bottom of the window do not update. If this either makes the design overweight or under-sinked, MML does not immediately mark it as invalid.

However, if you try to save the unit, MML will issue a warning about saving an invalid unit, so somewhere it does check the free heat sinks.

To reproduce:

  1. Load the standard Mule (2737), which for some reason has a military-grade engine. (Is that a bug?) It gets 121 heat sinks free, and has 121 heat sinks total. Its Burn Days 1G is 173.37, which is correct for a military engine.
  2. Uncheck the Military box. Nothing else changes on the screen. Burn Days 1G is still 173.37, there are still 121 free heat sinks, and the mass is still 11,200/11,200.
  3. Save the unit. The "Warning: Invalid unit, may save incorrectly!" message appears. The unit will be saved to data/mechfiles/ without prompting you for a location. (I thought this was fixed in an earlier version?)
  4. Validate the unit. The Mule is listed as 11262.0 tons, with the excess 62 being heat sinks. The Tonnage displayed at the bottom of the screen remains 11,200, and the red invalid flag at the bottom is still not there.
  5. Add and remove half a ton of fuel. Burn Days 1G correctly updates, as does the Tonnage displayed at the bottom. The unit is now clearly marked invalid.
  6. Reload the Mule from the cache and again uncheck the Military box.
  7. Remove one heat sink. The displayed number of weight-free heat sinks is still listed as 121, although the tonnage at the bottom now correctly indicates the design is 61 tons over and the invalid flag is visible.
  8. Reduce the speed to 2 and return it to 3. Now the number of weight-free heat sinks is correctly listed as 59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant