Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioGroup validation display issue #1571

Closed
adamhathcock opened this issue Dec 3, 2020 · 2 comments · Fixed by #1584
Closed

RadioGroup validation display issue #1571

adamhathcock opened this issue Dec 3, 2020 · 2 comments · Fixed by #1584
Labels
Type: Bug 🐞 Something isn't working
Projects
Milestone

Comments

@adamhathcock
Copy link
Contributor

Semi-related to: #1541 and #1231 and the bug I reported #1508 (which was fixed in 0.9.2.3, thanks!)

RadioGroup appears to need ChildContent for the individual radios. The documentation says otherwise. Just wanted to know what the intention was.

<RadioGroup TValue="string" @bind-SelectedValue="radioOption.Text">
            <ChildContent>
                <Radio Value="@("Option 1")">Option 1</Radio>
                <Radio Value="@("Option 2")">Option 2</Radio>
            </ChildContent>
            <Feedback>
                <ValidationError />
            </Feedback>
        </RadioGroup>

The Feedback section doesn't appear to display. I know the validation is working because using a ValidationSummary tag shows the feedback for the radiogroup.

@stsrki
Copy link
Collaborator

stsrki commented Dec 3, 2020

ChildContent must be used because Blazor does not allow for the use of content and custom render fragments at the same time. So they all need to be specified explicitly. It's mentioned in the documentation for validation https://blazorise.com/docs/components/validation/

As for missing Feedback. That is definitely a bug, and I will fix it for the next patch. Thanks for letting me know.

@stsrki stsrki added the Type: Bug 🐞 Something isn't working label Dec 3, 2020
@stsrki stsrki added this to 🔙 Backlog in Support via automation Dec 3, 2020
@stsrki stsrki added this to the 0.9.2 milestone Dec 3, 2020
@adamhathcock
Copy link
Contributor Author

Thank you!

@stsrki stsrki moved this from 🔙 Backlog to 💪 In progress in Support Dec 7, 2020
This was referenced Dec 7, 2020
@stsrki stsrki linked a pull request Dec 7, 2020 that will close this issue
@stsrki stsrki closed this as completed Dec 7, 2020
Support automation moved this from 💪 In progress to ✔ Done Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Support
  
✔ Done
Development

Successfully merging a pull request may close this issue.

2 participants