Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Multiple selection with checkboxes #3401

Closed
Tracked by #3575
David-Moreira opened this issue Feb 5, 2022 Discussed in #3397 · 4 comments · Fixed by #3870
Closed
Tracked by #3575

Autocomplete: Multiple selection with checkboxes #3401

David-Moreira opened this issue Feb 5, 2022 Discussed in #3397 · 4 comments · Fixed by #3870
Assignees
Labels
Area: Autocomplete Status : Finished Finished work on issue, to be closed (merge/review pending, etc...) Type: Feature ⚙ Request or idea for a new feature.
Projects
Milestone

Comments

@David-Moreira
Copy link
Contributor

Discussed in #3397

Originally posted by Lasoty February 4, 2022
A very useful component would be DropDown with a checkbox list.

image

@David-Moreira David-Moreira added this to the 1.1 milestone Feb 5, 2022
@David-Moreira David-Moreira self-assigned this Feb 5, 2022
@David-Moreira David-Moreira added Area: Autocomplete Type: Feature ⚙ Request or idea for a new feature. labels Feb 5, 2022
@David-Moreira David-Moreira added this to 🔙 Backlog in Development via automation Mar 10, 2022
@stsrki stsrki changed the title Multiple selection with checkboxes DropDownList: Multiple selection with checkboxes Mar 13, 2022
@David-Moreira
Copy link
Contributor Author

Starting work on this.
For this to make sense, then we need to have a "mode" where the selected items are still part of the list, right?
@stsrki ?

Because at the moment we remove the selected items from the search list:

Image below shows : Selected Western Sahara, and it is removed from the search list
image

Also not sure where the check all checkbox will be, it makes sense to be right besides where you type, but I think it's going to look weird, unless you make it look like in the example image in the first post, placed below.

@stsrki
Copy link
Collaborator

stsrki commented Jun 2, 2022

Aren't this going to be a part of DropdownList, not autocomplete? Or do you want to make it with autocomplete?

@David-Moreira
Copy link
Contributor Author

Oh I was going to do as part of AutoComplete haha. Which should be the component used for more advanced/complex features, in my opinion.

If we implement on DropdownList, then we need to make it so DropdownList now also supports multiple selection, etc... then people would want it to be able to search also (like seen in the image)... and you end up having a second AutoComplete like component?

@stsrki
Copy link
Collaborator

stsrki commented Jun 2, 2022

Now that I think about it. There were feature requests to have checks boxes on Autocomplete also 😅

@David-Moreira David-Moreira moved this from 🔙 Backlog to ⚙In progress in Development Jun 5, 2022
@David-Moreira David-Moreira added the Status : Finished Finished work on issue, to be closed (merge/review pending, etc...) label Jul 3, 2022
@David-Moreira David-Moreira moved this from ⚙In progress to ⏳ Review in Development Jul 3, 2022
@stsrki stsrki changed the title DropDownList: Multiple selection with checkboxes Autocomplete: Multiple selection with checkboxes Aug 16, 2022
@stsrki stsrki mentioned this issue Sep 19, 2022
49 tasks
Development automation moved this from ⏳ Review to ✔ Done Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Autocomplete Status : Finished Finished work on issue, to be closed (merge/review pending, etc...) Type: Feature ⚙ Request or idea for a new feature.
Projects
Development
  
✔ Done
Development

Successfully merging a pull request may close this issue.

2 participants