Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jumbotron should match the element size #4036

Closed
stsrki opened this issue Aug 9, 2022 · 0 comments
Closed

Jumbotron should match the element size #4036

stsrki opened this issue Aug 9, 2022 · 0 comments
Assignees
@stsrki
Labels
Type: Bug 🐞 Something isn't working
Projects
Support
Milestone
1.0 Support

Comments

@stsrki
Copy link
Collaborator

stsrki commented Aug 9, 2022

Currently, we always render h1 element for the jumbotron title. To be SEO compatible it should be rendered dynamically base on Size parameter.

<h1 id="@ElementId" class="@ClassNames" style="@StyleNames" @attributes="@Attributes">
    @ChildContent
</h1>

to

<Dynamic TagName="@($"h{GetHeadingElementSize()}")" id="@ElementId" class="@ClassNames" style="@StyleNames" @attributes="@Attributes">
    @ChildContent
</Dynamic>
@stsrki stsrki added the Type: Bug 🐞 Something isn't working label Aug 9, 2022
@stsrki stsrki added this to the 1.0 Support milestone Aug 9, 2022
@stsrki stsrki self-assigned this Aug 9, 2022
@stsrki stsrki added this to 🔙 Backlog in Support via automation Aug 9, 2022
This was referenced Aug 9, 2022
Merged
Closed
@stsrki stsrki closed this as completed Aug 9, 2022
Support automation moved this from 🔙 Backlog to ✔ Done Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stsrki stsrki

Labels
Type: Bug 🐞 Something isn't working
Projects
Support
  
✔ Done
Milestone
1.0 Support
Development

No branches or pull requests
1 participant
@stsrki