Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Column Chooser should show without requiring the pager to be visible. #5381

Closed
mtbayley opened this issue Mar 19, 2024 · 4 comments · Fixed by #5393
Closed

[Bug]: Column Chooser should show without requiring the pager to be visible. #5381

mtbayley opened this issue Mar 19, 2024 · 4 comments · Fixed by #5393
Labels
Type: Bug 🐞 Something isn't working
Projects
Milestone

Comments

@mtbayley
Copy link

Blazorise Version

1.5.0

What Blazorise provider are you running on?

Bootstrap5

Link to minimal reproduction or a simple code snippet

https://blazorise.com/docs/extensions/datagrid/features/column-chooser

Steps to reproduce

https://blazorise.com/docs/extensions/datagrid/features/column-chooser

What is expected?

Column Chooser should be visible if ShowColumnChooser = true

What is actually happening?

Column Chooser is only visible when ShowColumnChooser = true and ShowPager=true

What browsers do you see the problem on?

Microsoft Edge

Any additional comments?

Documentation isn't consistent with property names
image

@mtbayley mtbayley added the Type: Bug 🐞 Something isn't working label Mar 19, 2024
@mtbayley
Copy link
Author

Is it possible to have the column chooser work outside of a pager?
Or maybe some kind of Data Grid toolbar that is customizable?
Pager isn't a great name for it anymore if there is going to be other stuff shown.
This may help solve my feature request #5382

@David-Moreira
Copy link
Contributor

I guess you're right. We are kinda using the pager as an all purpose toolbar. So the naming is unfortunate.
I'm not sure about changing the name at this time though it's already been like that since forever, people might be used to it.
I would agree with the pager showing just the column chooser if ShowColumnChooser is set to true. And not needing to set ShowPager explicitly to true.
@stsrki thoughts?

@David-Moreira David-Moreira added this to 🔙 Backlog in Support via automation Mar 19, 2024
@stsrki
Copy link
Collaborator

stsrki commented Mar 20, 2024

I would agree with the pager showing just the column chooser if ShowColumnChooser is set to true. And not needing to set ShowPager explicitly to true.

I agree.

Regarding the naming of the pager. We definitely need to find a better name.

@mtbayley
Copy link
Author

Is it possible to create a new name and keep the previous name as an obsolete parameter for a few versions while people can transition?

I can cope, but for a new developer to Blazorise, the current name just isn't intuitive.

@David-Moreira David-Moreira linked a pull request Mar 21, 2024 that will close this issue
@stsrki stsrki added this to the 1.5 support milestone Mar 22, 2024
@stsrki stsrki closed this as completed Mar 22, 2024
Support automation moved this from 🔙 Backlog to ✔ Done Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Support
  
✔ Done
Development

Successfully merging a pull request may close this issue.

3 participants