Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] [Material] Issue with DetailRowTemplate in Editable DataGrid #622

Closed
MitchellNZ opened this issue Feb 29, 2020 · 3 comments · Fixed by #858
Closed

[DataGrid] [Material] Issue with DetailRowTemplate in Editable DataGrid #622

MitchellNZ opened this issue Feb 29, 2020 · 3 comments · Fixed by #858
Labels
Type: Bug 🐞 Something isn't working
Projects

Comments

@MitchellNZ
Copy link
Contributor

Describe the bug
I'm using Material Design UI and I have setup an editable DataGrid that also has a DetailRowTemplate.

The issue I get is that when the row is selected and the DetailRowTemplate is added, an extra empty is being added.
The backing control for this (_DataGridDetailRow.razor) has the following code which is causing me a problem:

if ( location == "end" && ParentDataGrid.Editable ) { <TableRowCell> </TableRowCell> }

This seemed to work fine when I was using Bootstrap, but now I'm using Material, it is causing the whole table to be push inwards (please see screenshots below).

To Reproduce
Steps to reproduce the behavior:

  1. Use Material Design
  2. Create an editable DataGrid with a DetailRowTemplate
  3. Select a row to expand the data grid detail row
  4. See the issue

Expected behavior
I think this was added to make Bootstrap look as intended, but it seems to be breaking Material.

Screenshots
Before selection:
image

After selection:
image

@stsrki stsrki added the Type: Bug 🐞 Something isn't working label Mar 2, 2020
@stsrki stsrki added this to the Backlog milestone Mar 2, 2020
@stsrki
Copy link
Collaborator

stsrki commented Mar 2, 2020

Hi @MitchellNZ, sorry for not answering before. It seems this is a bug indeed.

In the meantime you can try to use an updated version of material from https://github.com/djibe/material. The guy who maintain it is almost done but I think it's already safe to use.

@MitchellNZ
Copy link
Contributor Author

MitchellNZ commented Mar 2, 2020

@stsrki No worries.

Thanks for the workaround suggestion.
However, I tried importing the CSS from that library and it makes my UI look very different to the official Daemonite material library.
Is this going to be what you use in the next release?

Also, it doesn't fix the issue, unfortunately!
But I'm in no rush for a workaround.

Edit:
After further reading I see this is actually an updated version of Material, which explains the change in look!

@stsrki
Copy link
Collaborator

stsrki commented Mar 3, 2020

Yes I plan to use this one after it's finished. Unfortunately the original Daemonite material is not actively maintained and as far as I know there is no better alternative.

@stsrki stsrki modified the milestones: Backlog, 0.9.1 Apr 20, 2020
@stsrki stsrki added this to Backlog in Development via automation Apr 20, 2020
@stsrki stsrki moved this from Backlog to To do in Development Apr 20, 2020
@stsrki stsrki mentioned this issue Apr 20, 2020
49 tasks
@stsrki stsrki moved this from ⏳ To do to 💪 In progress in Development May 3, 2020
@stsrki stsrki linked a pull request May 3, 2020 that will close this issue
@stsrki stsrki closed this as completed May 3, 2020
Development automation moved this from 💪 In progress to ✔ Done May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Development
  
✔ Done
Development

Successfully merging a pull request may close this issue.

2 participants