Extreme FPS loss when animated items are on screen

[Sweenus]

Hey there,

I've identified a conflict between Simply Swords and Model Gap Fix that I assume will be an issue with any mod that has animated items.

To reproduce this issue the following steps can be followed:

1. Create a fresh fabric 1.19.2 or 1.20.1 instance
2. Install Simply Swords and its dependencies
3. Install Model Gap Fix
4. Launch game, open creative menu and scroll down in the Simply Swords tab
5. FPS will plumet as more animated items begin to be rendered

This issue is not present when Model Gap Fix is uninstalled. This issue does not occur when the alternate mod Item Model Fix is installed.

[Sweenus]

Hi there,

Is there any update on this issue?

To my knowledge, there is no alternative to Model Gap Fix for Minecraft 1.20+, and this is causing a very bad user experience for players, as both our mods are included together in many large modpacks.
I'd very much appreciate it if you could take a look 🙂

[MehVahdJukaar]

Well to the core this mod is a single mixj that sets atlash shrink ratio to 0. It also has more things to adjust item mods in particular. What do you think could cause the issue? Both are 2 very smal things, especially the first, that even just run when models are baked and that's it

[Sweenus]

Thank you for your reply!

Truthfully, I'm not experienced with the systems your code interacts with, so I couldn't say.
I do know that Item Model Fix does not have this issue - it might be worth crosschecking how they achieve this effect on items without FPS loss.

[MehVahdJukaar]

Mod code is really small you can check out for yourself. I assume simply sword is your mod so hhoe doe animated models work? Are they just special item renderers? I've seen many mods use them without any issue. As I've said my mod just changes very few lines of code that don't even get checked outside of model baking so unless you are baking models on the fly that shouldn't have any effect on rendering speed

[Sweenus]

Sorry for the delayed response!
The weapons in Simply Swords don't have any model animations. They are just standard item models with animated textures using spritesheets & mcmeta files. This issue isn't unique to Simply Swords - I've witnessed it occur with other mods using animated textures. Presumably it's only ocurring with texture animations containing many frames.

[JMackey1]

Came here to report the same issue. This mod practically locks my FPS to 10 when using an item with an animated texture, like a sword from Simply Swords. Disabling the mod causes my FPS to go back to 100+ consistently.

This is actually really easily demonstrated. Give yourself an animated sword from Simply Swords. Equip it and make it your active slot. Observe FPS. Change hotbar slot. Observe FPS.

Reproducible just with this, Simply Swords, and dependencies.