-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.3 does not work with fresh generated library based on netstandard2.0 #13
Comments
Sorry for the late reply. I never got a notification about this. It's possible it got lost in a spam filter somewhere because I know I've been getting notifications for other repos I'm part of. Anyway. I need to get back to this. I put things on hold because so far I've been dissatisfied with Visual Studio's support for building source generators so far. Once they're built they work just fine, but the authoring and debugging process itself is still far too painful. It's getting a little better though. I'm hoping to have a fully working and customizable BuilderGenerator in place before my previous course goes stale enough to justify redoing things, or maybe just the last module. I'll run a quick test and see what I find though. |
I just created a brand new netstandard2.0 project and added builders to it. I didn't get the same error you've included above, but I did get an error that sounds more closely related to your description. Instead, I got: |
I'm going to need to test this out a bit before I create a new version, but I think that if I make the generated code so that it's unaware of nullable types then it's going to be unhappy in .Net 5+ projects. Since that's the future, that's what I'm targeting now. |
Thanks a lot for your respond. Meanwhile I forked the project and tried sth. by myself but without a result I´m fine with. |
Hi, |
I am finishing up the last module of a new Pluralsight course this week and next. After that, I'll be free to get back to the generator and I hope to have some blog content about that when I'm done as well. |
I wanted to let you know I'm back on this, and I can see the same error as you now, down to the line number, so that's a good start. |
* Merged from main * #13 fixed netstandard2.0 compatibility
Hi,
I´m following your project since I saw your great video module on pluralsight.
Since that I`m waiting on the version 2 which applies muich easier ways to generate code.
Thanks for your great work by the way.
Unfortunately it seems that the current version 2.0.3 is not completely compatible with netstandard 2.0. I have to use it because my project is still based on .Net Framework 4.8 and not yet ported to .net 3.1 neigher to .net 5 or 6.
I`m using your package in a own library which depends also on my model library which is still targeting ".Net Framework 4.8". Do I have to change the target framework to ".netstandard2.0" as well?
When I´m trying to build the project, it shows me the following error:
![image](https://user-images.githubusercontent.com/12536051/158037459-123ec4f0-ad49-4ab5-b978-9cf13b0b4170.png)
My first thought was that I have to enable nullable types in my project but this did not help neigther
The error occures in:
BuilderBaseClass.cs 28
Can you check this please?
Thanks a lot
Greetings from Munich (Bavaria, Germany)
The text was updated successfully, but these errors were encountered: