Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Refactor #9

Closed
MelbourneDeveloper opened this issue Dec 30, 2018 · 2 comments
Closed

Android Refactor #9

MelbourneDeveloper opened this issue Dec 30, 2018 · 2 comments

Comments

@MelbourneDeveloper
Copy link
Owner

The AndroidUsbDevice class is a mess. There is logic there that is mixed up between scanning for devices, receiving events, and polling.

-Implement the factory pattern in other platforms
-Remove any CheckForDevice methods and deal with this in some other way
-This issue is dependent on #3 because polling is necessary on Android
@MelbourneDeveloper MelbourneDeveloper added this to In Progress in Release 2.4.0 Dec 30, 2018
MelbourneDeveloper added a commit that referenced this issue Dec 31, 2018
@MelbourneDeveloper
Merge branch 'develop' into #9-AndroidRefactor
8597992
@MelbourneDeveloper MelbourneDeveloper moved this from In Progress to Maybe in Release 2.4.0 Dec 31, 2018
MelbourneDeveloper added a commit that referenced this issue Jan 4, 2019
@MelbourneDeveloper
Merge branch 'develop' into #9-AndroidRefactor
26fc2e6
MelbourneDeveloper added a commit that referenced this issue Jan 5, 2019
@MelbourneDeveloper
Merge branch 'develop' into #9-AndroidRefactor
1857ba3
MelbourneDeveloper added a commit that referenced this issue Jan 5, 2019
@MelbourneDeveloper
Merge branch '#9-AndroidRefactor' into #9-AndroidRefactorPolling
1349b82
@MelbourneDeveloper MelbourneDeveloper moved this from Maybe to In Progress in Release 2.4.0 Jan 6, 2019
@MelbourneDeveloper MelbourneDeveloper moved this from In Progress to Mostly Done in Release 2.4.0 Jan 6, 2019
MelbourneDeveloper added a commit that referenced this issue Jan 7, 2019
@MelbourneDeveloper
Merge branch 'develop' into #9-AndroidRefactor
b5bf788
MelbourneDeveloper added a commit that referenced this issue Jan 7, 2019
@MelbourneDeveloper
Merge branch '#9-AndroidRefactor' into #9-AndroidRefactorPolling
5a71dea
MelbourneDeveloper added a commit that referenced this issue Jan 12, 2019
@MelbourneDeveloper
Merge branch '#9-AndroidRefactorPolling' into develop
bdb27ab
@MelbourneDeveloper
Copy link
Owner Author

Done in 2.3

1 similar comment
@MelbourneDeveloper
Copy link
Owner Author

Done in 2.3

@MelbourneDeveloper MelbourneDeveloper removed this from Mostly Done in Release 2.4.0 Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MelbourneDeveloper