Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: convert to vue composition with ts. add types. #149

Closed
wants to merge 15 commits into from

Conversation

209
Copy link

@209 209 commented Mar 18, 2023

convert to vue composition. add types.

Description

Motivation and Context

Becose in 2023 we need types.

How Has This Been Tested?

Not

Need help for prod-ready)
I've changed initialization plugin.

@209
Copy link
Author

209 commented Mar 20, 2023

I've converted, but.. project hasn't been worked.
Need help)

@jhrncar
Copy link

jhrncar commented Mar 25, 2023

Hi, i am using this package in my bacchelor's thesis and I need types. is this PR working? is there any chance i could get it withou merging? cause as i look at this repo, it seems the cretor doesn't interact

@209
Copy link
Author

209 commented Mar 25, 2023

@jhrncar Hi, I've stabled this PR: all is ok, I think.
package: https://www.npmjs.com/package/@i209/vue3-openlayers
You need add components.d.ts to tsconfig inlude for get declaring global imports.

build types: It's no the best realisation. I haven't enoght experience to make a excellent build.

Troubles: default example in repo has low performace.
Some of features works bad.
I haven't found a reason, sorry. You can try to remove different parts of App.vue template and find problem part.
But my realistic examples work similar as original.

If you want, you can send me PR with updates/fixes/chages.

I don't want to support my PR long time alone.
The convert work to ts + composables was realy boring. And more points haven't described enough.
I hope the author will return =) I haven't enough experience in original OpelLayer lib.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for vue3openlayers2 failed.

Name Link
🔨 Latest commit 0862c67
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers2/deploys/64234f97a076d60008cb2bab

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for vue3openlayers ready!

Name Link
🔨 Latest commit 0862c67
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/64234f977a78090008b0c5d5
😎 Deploy Preview https://deploy-preview-149--vue3openlayers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@209
Copy link
Author

209 commented Mar 28, 2023

I've rebased PR.

@d-koppenhagen
Copy link
Collaborator

@209 do you still need help? Would you mind to rebase this PR again?

@209
Copy link
Author

209 commented May 6, 2023

@209 do you still need help? Would you mind to rebase this PR again?

I spent 2 weeks doing a boring job that no one gives a shit about.
I'm sorry, but the main branch has gone too far ahead.

I am not ready to spend 4-8 hours on a rebase if there is no guarantee that someone will consider my branch.
Now we need to review each changed file, evaluate the changes and implement them very carefully.

@d-koppenhagen
Copy link
Collaborator

d-koppenhagen commented May 7, 2023

@209 I understand your frustration.
I am personally very interested in this change an I think your PR is a great win for the project which makes it way more modern!
Big kudos for all your effort.

I recently got a maintainer for this project. I can tell you I would like to bring this PR to production, once it's ready.

I will also try to support you with the work of rebasing (hopefully I will find some time within the next days).

@d-koppenhagen
Copy link
Collaborator

Hey @209 thanks for all the time you invested which wasn't waste. Meanwhile I picked a lot of TS migrations from your branch and migrated the codebase step-by-step to typescript and script setup. Please checkout the lastest releases (1.0.0-alpha.7 and probably above).
Once 1.0.0 is stable I will definitely add you to the release notes.
Nonetheless, this PR can be closed, as it's obsolete now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants