Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using controls as childs of bar #248

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

lukas-zaugg
Copy link
Contributor

@lukas-zaugg lukas-zaugg commented Sep 12, 2023

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (Tooling, Dependency Updates, etc.)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:

  • Add component to output.globals in vite.config.ts
  • Create a src/demos/<Component>Demo.vue
  • Create a docs/componentsguide/<Category>/<Feature>/index.md containing the Demo and documentation for the component
  • Add the docs page to docs/.vitepress/config.ts
  • Update the sitemap docs/public/sitemap.xml

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for vue3openlayers ready!

Name Link
🔨 Latest commit 7b30104
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/65001ac09bcbac00081c89d7
😎 Deploy Preview https://deploy-preview-248--vue3openlayers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@d-koppenhagen
Copy link
Collaborator

Would you mind to provide an example for the docs too?

@lukas-zaugg
Copy link
Contributor Author

@d-koppenhagen The example is there already in the demo, but it is not working without this fix:
AppDemo.vue
There should be a toolbar on the map showing some controls for drawing, screenrecording etc.

@d-koppenhagen d-koppenhagen merged commit 21b6703 into MelihAltintas:main Sep 13, 2023
5 checks passed
chrstnbwnkl pushed a commit to chrstnbwnkl/vue3-openlayers that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants