Single temperature for high-core CPU's

[to4ko]

Hi!

Is it possible to modify script to get single number (Package id 0) readings on summary screen instead of 14?)

[Meliox]

Hello,
Should work if you change this line: https://github.com/Meliox/PVE-mods/blob/main/pve-mod-gui-temp.sh#L115C6-L115C21 to "Package id " instead.

[to4ko]

Hello, Should work if you change this line: https://github.com/Meliox/PVE-mods/blob/main/pve-mod-gui-temp.sh#L115C6-L115C21 to "Package id " instead.

thanks!

[Meliox]

I mean change it from: CPU_ITEM_PREFIX="Core " to CPU_ITEM_PREFIX="Package id ". However, the line indicate something is wrong in or around line 15. https://github.com/Meliox/PVE-mods/blob/main/pve-mod-gui-temp.sh#L15 Den man. 17. jul. 2023 kl. 21.17 skrev Dmitry ***@***.***>:

…

Hello, Should work if you change this line: https://github.com/Meliox/PVE-mods/blob/main/pve-mod-gui-temp.sh#L115C6-L115C21 to "Package id " instead. i'm doing something wrong? [image: image] <https://user-images.githubusercontent.com/45161980/254046757-90f3072c-3f0b-4d4e-939b-d13c79296098.png> — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIFH4GG3OAJWBUCDU2E66LXQWFU7ANCNFSM6AAAAAA2NLLCIM> . You are receiving this because you commented.Message ID: ***@***.***>

[to4ko]

@Meliox one more - how this empy space can be removed?

[Meliox]

This is not caused by the mod, hence, I would ask, or fill a bug, to the proxmox team.

Btw. If you want to change "Core 0" to "Package 0", then simply change this line: https://github.com/Meliox/PVE-mods/blob/main/pve-mod-gui-temp.sh#L116

Non-modded:

[to4ko]

it;s strange - here is mine non-moded

[Meliox]

Can you share your non-modded file for comparison?

[to4ko]

attached
pvemanagerlib_and_Nodes_pm.zip

[Meliox]

Thanks.
Ok, mine had some leftovers (right):

So, I guess we can conclude that something in this section makes the unwanted behavior.

https://github.com/Meliox/PVE-mods/blob/main/pve-mod-gui-temp.sh#L190

[eremem]

@Meliox I doesn't really look like our bug. Regardless of the modified height, bodyPadding and the other properties, the actual height of the box must grow anyway due to the added temperature entries. The layout manager of ExtJS (the JS framework under the hood) doesn't seem to be able to vertically align the boxes if their heights differ.

[carlox97]

I edited Line 15 and 16 to
CPU_ITEM_PREFIX="Package id "
CPU_TEMP_CAPTION="CPU Package"

Line 233 to
tempStr = \`\${cpuTempCaption}: \${temp}°C\`;\n\

to get "CPU Package: 52°C"

and Line 325 to
temps.push(\`Samsung \EVO \960: \${temp}°C\`);\n\

to get "Samsung EVO 960: 27.85°C"

@Meliox do you think it's fine or it might cause problems? I've had none so far.

[Meliox]

Looks great. It will not cause you any problems. You will need to modify the script again if this one is updated.