-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding DB support #22
adding DB support #22
Conversation
Hey @Melkeydev, would appreciate your feedback on the implementation, let me know what could have been done better or if there's anything I might have missed in it. |
# Conflicts: # README.md # cmd/program/program.go
I'm planning on improving upon this by adding some prompts for a .env file? I mean that is I mostly use DB drivers....so would that be cool? |
I could also probably add some fields like
I could use the popular https://github.com/joho/godotenv package? |
Do we need to introduce another package to lead .env vars or can we just use the standard os lib? |
True....we can probably just read of the os lib as a default, but have an option of a .env? moreover, godotenv is quite a popular package with good reputation |
Good points I am OK to add godotenv to either this repo or a following one |
@MohammadAlhallaq There are some new merge conflicts due to previous merges! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments - tested out the PR everything seems to work however,
the DB doesnt actually get hooked up.
Wondering if there is a way we can fully test out this feature and implement it for a user to use
I will tackle those asap, and try to figure out a way to make the service accessible via a route for testing |
Ping me when this is ready for a another review :) |
# Conflicts: # cmd/create.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks
Fucking
Incredible
To Me
My honor to MERGE THIS
thanks man, I've really enjoyed working on it. |
#11