issue: 3981627 [GTEST] Fix default gateway detection #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys_str2addr() converts a string address representation to the sockaddr structure. However, an invalid address sets either AF_INET or AF_INET6 address family and returns corrupted IP portion of the sockaddr object. Return AF_UNSPEC address family in case of an invalid IP address. So, default gateway detection can handle address parsing. Invalid port portion is still silently ignored. In the future, the function should return the conversion status and this needs to be handled explicitly by the function users. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
sys_gateway() converts string address to a temporary sockaddr object on stack before changing the result object. However, a different uninitialized object is checked for the conversion status. Check the correct object. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sys_str2addr() converts a string address representation to the sockaddr
structure. However, an invalid address sets either AF_INET or AF_INET6
address family and returns corrupted IP portion of the sockaddr object.
Return AF_UNSPEC address family in case of an invalid IP address. So,
default gateway detection can handle address parsing.
Invalid port portion is still silently ignored. In the future, the
function should return the conversion status and this needs to be
handled explicitly by the function users.
sys_gateway() converts string address to a temporary sockaddr object
on stack before changing the result object. However, a different
uninitialized object is checked for the conversion status.
Check the correct object.
What
Fix default gateway detection.
Why ?
Fix incorrect gateway detection in corner cases.
Change type
What kind of change does this PR introduce?
Check list