Cleanups #913
Draft
Cleanups #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross-compiling, the test binary used to verify basic std::regex functionality will always fallback on GNU regex which may not necessarily be the expected behavior. This patch assumes that the cross-compiler has complete std::regex support. It is the developer's responsibility to verify the functionality of std::regex of the cross-compiler in use. Signed-off-by: Markus Theil <theil.markus@gmail.com>
The musl toolchain doesn't have <sys/pci.h>, only <linux/pci.h>, resulting in a compilation error. This patch checks if <sys/pci.h> is present and alternatively uses <linux/pci.h> if not. Signed-off-by: Til Kaiser <mail@tk154.de>
Description: When Hotplug is activated, resetting the device causes the bdf to change. As a result, running lspci on the previously known bdf will not be successful due to the altered bdf. Running mst restart is necessary to re-enumerate the mst devices. MSTFlint port needed: Yes Tested OS: Linux, pcie-hpg11-01 Tested devices: mt4125 Tested flows: mlxfwreset -d /dev/mst/mt4125_pciconf0 --sync 1 -y r --log debug Known gaps (with RM ticket): Issue: 3720202 Change-Id: Ie3f03115351921086717e3b94670bf9219f88333 Signed-off-by: Itay Avraham <itayav17@gmail.com>
… inform the user about it
Description:
The purpose of this feature is to give users an indication of what will happen when they execute the reset flow using mlxfwreset while the BF is in controller mode.
When a full chip reset is triggered, and there are no additional hosts except for the ARM itself (especially in controller mode), the ARM will reset the entire DPU.
This includes an ARM reset, and it immediately initiates an ARM OS shutdown.
During this process, the setup will be unavailable for some time, which the user may not expect.
The solution is to check the reset type:
The message will not printed to the user when the reset type is bit 1 ("Keep network port active during reset") or bit 2("NIC only reset for SoC devices").
MSTFlint port needed: Yes.
Tested OS: BF Controller (10.7.4.188) and regular BF (apps-173)
Tested devices: BF3
Tested flows: mlxfwreset -d /dev/mst/mt41692_pciconf0 r
Known gaps (with RM ticket):
Issue: 3725353
Change-Id: If7af544b380b1e275f15383d0803bfd6943972f0
Signed-off-by: Itay Avraham <itayav17@gmail.com>
Description: The supported switches for MRSR-1 that are already supported in mlxfwreset: Spectrum, Spectrum-2, Spectrum-3, Switch-IB, Switch-IB-2, Quantum, Quantum-2. The supported switches for MRSR-6 that have not been implemented yet and need to be addressed with a new feature request: Quantum-3, Spectrum-4 and above MSTFlint port needed: No. Tested OS: Linux (Mellanox OS) Tested devices: All switches. Tested flows: mlxfwreset -d <switch> r Known gaps (with RM ticket): Issue: 3738146 Change-Id: Ic3e3b555dd811098675c3fbd70996a75aa06204b Signed-off-by: Itay Avraham <itayav17@gmail.com>
Description: [mlxlink] - update amber collect to version 2.8 MSTFlint port needed: yes Tested OS: None Tested devices: None Tested flows: None Known gaps (with RM ticket): Issue: 3698551
Description: updating the supported compliance speed MSTFlint port needed: None Tested OS: None Tested devices: None Tested flows: None Known gaps (with RM ticket): Issue: 3741924
… of MGIR Description: requested by FR, since MGIR returned the wrong value for NDR SP4 We changed it first to SLRG - but this register has a FW bug when running in 25G per lane or less. So switched to SLTP. MSTFlint port needed: Tested OS: Tested devices: Tested flows: Known gaps (with RM ticket): Issue: 3706030 Issue: 3747125
…o sp2 & sp3 adb files. Description: Auto generated code MSTFlint port needed: yes Tested OS: Tested devices: Tested flows: Known gaps (with RM ticket): Issue: None
Description: MSTFlint port needed: no Tested OS: Tested devices: Tested flows: Known gaps (with RM ticket): Issue: None
Description: MSTFlint port needed: no Tested OS: Tested devices: Tested flows: Known gaps (with RM ticket): Issue: None
Description: Fixing NDR modulation config in prbs testmode MSTFlint port needed: Yes Tested OS: Linux64 Tested devices: QTM-2 Tested flows: mlxlink prbs test_mode Known gaps (with RM ticket): NA Issue: 3612477
Description: -Cleaning mlxlink_commander from any user input parameters -Moving all user input parameters to UserInput class MSTFlint port needed: No Tested OS: Linux64 Tested devices: CX-6 Tested flows: mlxlink full test Known gaps (with RM ticket): NA Issue: 3554777
Description: Adding new flag (--plane) to the internal tool for plane view The default view will be aggregate view If the plane is provided then the tool will set plane_ind field for all access reg requests MSTFlint port needed: Yes Tested OS: Linux64 Tested devices: NA Tested flows: mlxlink --plane X Known gaps (with RM ticket): NA Issue: 3566234
…g a text format public key Description: plain text public key (without authentication_configuration struct) will be applicable for rsa_sign command if the same key was already inserted prior to signing. MSTFlint port needed: no Tested OS: linux Tested devices: image Tested flows: rsa_sign CX7 bin with a plaintext pub key that's already in public_keys_2/3 => success rsa_sign CX7 bin with a new plaintext pub key => failed rsa_sign CX7 bin with a new public_key_2/3 pub key => success Known gaps (with RM ticket): N/A Issue: 3611237
…W update from ARM side Description: MCC update handle initializtion removed from FwCompsMgr init, will be performed lazily right before each call to read/write. MSTFlint port needed: yes Tested OS: linux Tested devices: BF3, CX7 Tested flows: flint query on BF3 with disabled FW update, flint query on CX7, flint burn on CX7 Known gaps (with RM ticket): N/A Issue: 3580180
Description: added support for arcuse 4mb flash MSTFlint port needed: yes Tested OS: linux Tested devices: non secure arcuse PLD Tested flows: flint -ocr q on virtual mtusb Known gaps (with RM ticket): N/A Issue:3635328
Description: added support for new winbond and micron flashes MSTFlint port needed: yes Tested OS: linux Tested devices: CX7 with new flashes Tested flows: flint hw query, flint -ocr burn Known gaps (with RM ticket): N/A Issue: 3664099
Description: added support for FS5 image burn start MSTFlint port needed: yes Tested OS: linux Tested devices: QM3 emu Tested flows: flint -d -i burn Known gaps (with RM ticket): N/A Issue: 3666597 Change-Id: I1a9d2a8c1ff70e7e717cf49af824a5492961b334 Signed-off-by: Alex Shargorodsky <ashargorodsk@nvidia.com>
Description: added FS5 support for -ocr burn. MSTFlint port needed: yes Tested OS: linux Tested devices: QM3 Tested flows: flint -ocr burn Known gaps (with RM ticket): N/A Issue: 3672348 Change-Id: I5d3d5d9275e08c579c85e03818547ba795de3ed5 Signed-off-by: Alex Shargorodsky <ashargorodsk@nvidia.com>
Description: added CX8 sw_dev_id MSTFlint port needed: yes Tested OS: linux Tested devices: N/A Tested flows: mlxburn -fw mlx -wrimage /tmp/tmp_file.bin -c ini -base_guid 0x0002c903002ef500 -base_mac 0x0002c92ef500 -dev_type 4131 Known gaps (with RM ticket): N/A Issue: 3676569
…w DTOC offset Description: support for configuration of root node selection for multi root mlx files. The ini file will have a "root" field under a "[CONF_FILE_INFO]" section, this field will determine the root node. In addition, "image_info" itoc section will have a new field "dtoc_offset", indicating where to look for the dTOC header in the image. MSTFlint port needed: yes Tested OS: linux Tested devices: N/A Tested flows: Generate images from multi root cx7 mlx file. Generate image from non multi root cx7 mlx file. Generate image from cx7 mlx file. Known gaps (with RM ticket): N/A Issue: 3673629
Description: added new MCC error and error string MSTFlint port needed: yes Tested OS: N/A Tested devices: N/A Tested flows: N/A Known gaps (with RM ticket): N/A Issue: 3675014 Change-Id: Ica189d09f336d8af1ddefbc558e1f4c1ba94758d Signed-off-by: Alex Shargorodsky <ashargorodsk@nvidia.com>
Description: added fclose for each sigSection update. MSTFlint port needed: yes Tested OS: linux Tested devices: N/A Tested flows: mlxdpa sign_dpa_apps -> check that sections have sigSection string Known gaps (with RM ticket): N/A Issue: 3713572 Change-Id: I1c4ea0a755d6a0af3e561270ea8c7bf2a7815cbb Signed-off-by: Alex Shargorodsky <ashargorodsk@nvidia.com>
Description: changed VPD check from forcing it to a fixed offset to checking section max size. MSTFlint port needed: yes Tested OS: linux Tested devices: CX7 Canoe Tested flows: flint -d <device> -ocr set_vpd <file> Known gaps (with RM ticket): N/A Issue: 3716449 Change-Id: I14e0758e9f7d661f7c0f0c6faa88666f4c0c57c2 Signed-off-by: Alex Shargorodsky <ashargorodsk@nvidia.com>
…ulation header Description: 1) for BCH generation - digest and signature in encapsulation header are calculated only on actual fw data (up to burn image size) 2) for burn flow - FwExtract4MBImage should check if encapsulation header is part of image to extract it for fw update flow 3) DTOC offset calculation changed after appending encapsulation header to the image MSTFlint port needed: no Tested OS: linux Tested devices: QM3 palladium Tested flows: flint fw upgrade Known gaps (with RM ticket): N/A Issue: 3729517
Description: adding to itoc_type for flint verify prints MSTFlint port needed: yes Tested OS: linux Tested devices: image Tested flows: flint verify on an image with FW_DUMP section Known gaps (with RM ticket): N/A Issue: 3733393
…w offsets Description: fixed init for set_signed_fw_components command MSTFlint port needed: yes Tested OS: linux Tested devices: N/A Tested flows: flint set_signed_fw_components on QM3 image Known gaps (with RM ticket): N/A Issue: 3733745 Change-Id: I61dd383fd5605c70d163cc8c1adb8c98422c57dd Signed-off-by: Alex Shargorodsky <ashargorodsk@nvidia.com>
…anoe Description: fixed dtoc offset calculation for prod burn with encrypted image MSTFlint port needed: yes Tested OS: linux Tested devices: Canoe Tested flows: flint prod burn Known gaps (with RM ticket): N/A Issue: 3743316 Change-Id: I6e37d66802706f7a59cc647467c1e825aee32e31 Signed-off-by: Alex Shargorodsky <ashargorodsk@nvidia.com>
…tead of secure-host related info Description: checking if secure host is locked in case of MCC flow initialization MSTFlint port needed: yes Tested OS: linux Tested devices: CX6 Tested flows: flint q after setting hw_access disable Known gaps (with RM ticket): N/A Issue: 3699666
Description:
mlxlink failed with '-E- Showing PDDR raised the following exception:
Failed to send access register: Bad parameter'
There is a problem that if the device doesn't support PDDR reg with select_page=3 the tool won't work, even though it dosn't need that info for all flags of mlxlink.
Changing that the function will be called only for flags that need that informantion.
MSTFlint port needed: None
Tested OS: None
Tested devices: None
Tested flows: mlxlink -d {device}
Known gaps (with RM ticket): None
Issue: 3649766
Description: Fixing error types in the help menu Fixing erro message while providing invalid error parameter Adding missing info message while configuring FEC for main\tile ports MSTFlint port needed: Yes Tested OS: Linux64 Tested devices: CX7, SPC-3 Tested flows: mlxink full commands Known gaps (with RM ticket): NA Issue: 3577410 Issue: 3541189 Issue: 3567074
Description: - Supporting the new serdes_tx params for XDR generation - Supporting eye info MSTFlint port needed: No Tested OS: Linux64 Tested devices: NA Tested flows: mlxlink eye_info mlxlink serdes_tx Known gaps (with RM ticket): NA Issue: 3482368 Issue: 3700963
Description: fixed uninitialized variables coverity issues. Tested OS: linux Tested devices: n/a Tested flows: compilation Known gaps (with RM ticket): n/a Issue: 3657795
Description: The port flag will take the IB port number for BW port access MSTFlint port needed: Yes Tested OS: Linux64 Tested devices: BW00 Tested flows: mlxlink full commands Known gaps (with RM ticket): N/A Issue: 3509849
…r "[u]?int[0-9]+_t"-family of types.
This commit addresses compilation failure below, which is caused
by changes in standard headers on modern versions of GCC:
In file included from elfio/elfio.hpp:34,
from cryptodata.cpp:15:
./elfio/elf_types.hpp:30:20: error: 'uint16_t' does not name a type
30 | using Elf_Half = uint16_t;
| ^~~~~~~~
./elfio/elf_types.hpp:1:1: note: 'uint16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
+++ |+#include <cstdint>
1 | /*
See https://gcc.gnu.org/gcc-13/porting_to.html for reference.
(cherry picked from commit bc33aa0)
Signed-off-by: AlexBlago <alexbl@nvidia.com>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
FIXME: why is that OK? Also: removed ignoring a warning that already worked. Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
FIXME: How can we be sure those copies are safe? Signed-off-by: Tzafrir Cohen <mellanox@cohens.org.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.