-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor docker tag and helm version determination via triggers #945
Conversation
Pull Request Test Coverage Report for Build 9169939491Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, otherwise LGTM
run: | | ||
git_tag=${{ github.ref_name }} | ||
app_version=$git_tag | ||
chart_version=${git_tag:1} # without the 'v' prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Can do after the merge, just so we don't forget) Need to make a test release to check that all versions in the helm chart / image versions are correct
Signed-off-by: Michael Zeevi <mzeevi@nvidia.com>
CI failures are not related to this change, so it's safe to merge |
Git tag events (regardless of the branch) would not trigger the old workflow, and push branch events would trigger it - including the Helm CI, which would sometimes not be able to determine any version to set, thus failing.
This commit fixes the above, by: