Run without itimer support in alpine #143
Conversation
|
Can one of the admins verify this patch? |
| @@ -33,7 +33,8 @@ | |||
| #include <unistd.h> | |||
| #include <stdlib.h> | |||
| #include <signal.h> | |||
| #include <sys/poll.h> | |||
| #include <stdio.h> | |||
There was a problem hiding this comment.
Why is stdio.h being included to vma-redirect.h when vma-redirect.cpp has not been touched? Not clear to me.
There was a problem hiding this comment.
Same here, this is another change required to build sockperf in alpine OS
| @@ -103,6 +103,7 @@ with simple integral values. The following describes these calculations: | |||
| #endif | |||
|
|
|||
| #include "ticks_os.h" | |||
| #include "os_abstract.h" | |||
There was a problem hiding this comment.
Same here, I see that you use os_thread_t in file client.cpp. Why not include header os_abstract.h in client.h?
There was a problem hiding this comment.
This is one of the changes required to properly build in alpine OS, the program was not able to find this file
|
Hi @salsal97, could you provide a motivation not to use |
|
@igor-ivanov , I am running this code inside an Intel SGX secure enclave that does not have support for the itimers syscall yet, hence these modifications in the upstream help us |
|
@igor-ivanov, the changes made to client.cpp support the use of intel sgx enclaves, which might have itimer support as well in the future |
|
bot:retest |
Added changes to -